GitLab

One override of this method was a replacement with an
identical implementation in BubbleDialogDelegateView. The other was
BaseDialogContainer, which is part of the app info dialog.

BaseDialogContainer originally moved *from* using a DialogClientView *to* using
its own ClientView to fix https://crbug.com/445695, which was about the dialog
having a strange default button. Since that time, DialogClientView became
perfectly happy to have no default button, so I think that fix is now obsolete.
That allows BaseDialogContainer to use DialogClientView again, which means most
of the reimplementation of DialogClientView there can be removed.

Unfortunately there is one remaining override of this method, in
AssistantContainerView, so it can't yet be marked final.

Bug: 1011446
Change-Id: I9331e847ec2572b4d6dc5e5e2909882ececd9da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856538Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705575}