• Marijn Kruisselbrink's avatar
    Remove DefaultHash<scoped_refptr<const SecurityOrigin>>. · 1cd35197
    Marijn Kruisselbrink authored
    The existance of this DefaultHash implementation is potentially problematic
    for several reasons:
    
    - DefaultHash<scoped_refptr<T>> exists as well, making it very easy to end up
      with ODR violations where different translation units end up with different
      types for a HashSet<scoped_refptr<const SecurityOrigin>>.
    - It is not obvious what "equality" the hash implements, since there are at
      least two equally valid definitions of equality for origins ("same origin"
      vs "same origin-domain").
    
    Currently no code is actually using this hash, but our upcoming DOMStorage
    onion souping will want a hash that implements same origin equality, so
    for that this also changes the implementation to implement that version of
    equality.
    
    Bug: 781870
    Change-Id: I79d8820194b51cb81ba4bf0684e65cba575dba82
    Reviewed-on: https://chromium-review.googlesource.com/1229357Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
    Reviewed-by: default avatarMike West <mkwst@chromium.org>
    Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#592536}
    1cd35197
database_tracker.cc 9.71 KB