• Josh Nohle's avatar
    [Nearby] Reset URL loader and stream parser before invoking callback · 1cf4c5ff
    Josh Nohle authored
    We make a few simple changes to help diagnose the crash occurring in
    https://crbug.com/1162157:
    
    1) Reset the URL loader and stream parser before invoking the callback
       to ensure we stop streaming before any callback side effects occur.
    2) Add a CHECK to OnDataReceived() to ensure the stream parser is not
       null. Will change to DCHECK when the crash is resolved.
    3) In the stream parser, use the native StringPiece methods to get
       the underlying data and string length.
    4) Add additional VERBOSE logging to ReceiveMessageExpress.
    
    I'm skeptical that these changes will fix the crash, but they will
    help eliminate some possibilities.
    
    Bug: 1162157
    Change-Id: Ic1eef5c4bf0d047c66420aad29cbd3d93992ba05
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627564
    Commit-Queue: Alex Gough <ajgo@chromium.org>
    Reviewed-by: default avatarAlex Gough <ajgo@chromium.org>
    Reviewed-by: default avatarJames Vecore <vecore@google.com>
    Auto-Submit: Josh Nohle <nohle@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#843119}
    1cf4c5ff
receive_messages_express.h 2.92 KB