• Takashi Toyoshima's avatar
    Reland "Reland "Split WebKit platform build file"" · 1cf9f36e
    Takashi Toyoshima authored
    test_support of platform/loader and platform/network should
    depends on //storage/public/interfaces:interfaces_blink__generator
    because it indirectly includes generated mojo interface headers.
    
    This is the root cause of the original issue, and it seems
    BUILD file splitting makes it happens more easily.
    
    This is a reland of 997ce7ad
    Original change's description:
    > Reland "Split WebKit platform build file"
    > 
    > platform/network/BUILD.gn lacked mojo_bindings_blink dependency.
    > This caused a race on compiling.
    > 
    > This is a reland of 080c70a7
    > Original change's description:
    > > Split WebKit platform build file
    > > 
    > > A race condition was found in the build of //third_party/WebKit/Source/platform/loader.
    > > To resolve it necessary to extract targets  //third_party/WebKit/Source/platform/blob and //third_party/WebKit/Source/platform/network form //third_party/WebKit/Source/platform. And add correct dependencies where it is needed.
    > > All of these done in this CL.
    > > 
    > > Original author is apisarev@yandex-team.ru, and toyoshim@chromium.org takes over it
    > > to submit since it needs quick rebase works to catch up HEAD.
    > > 
    > > Bug: 754600
    > > Change-Id: I5f70348fac10f270df99b658608cf23685ed937e
    > > Test: gn check out/Release && ninja -C out/Release
    > > Reviewed-on: https://chromium-review.googlesource.com/612284
    > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    > > Reviewed-by: Daniel Bratell <bratell@opera.com>
    > > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > > Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#508661}
    > 
    > TBR=engedy@chromium.org
    > 
    > Bug: 754600
    > Change-Id: I250e67581e61e1d36c32b01ccad3372b442c08bc
    > Reviewed-on: https://chromium-review.googlesource.com/718243
    > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#508993}
    
    TBR=engedy@chromium.org
    
    Bug: 754600
    Change-Id: Ia1231a3ee2213bb44474bd8ffeacf67b86002bfd
    Reviewed-on: https://chromium-review.googlesource.com/720542
    Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
    Reviewed-by: default avatarTakashi Toyoshima <toyoshim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#509359}
    1cf9f36e
BUILD.gn 35.3 KB