• Oriol Brufau's avatar
    [css-grid] Use min-content size for intrinsic maximums resolution · 1d01cbaf
    Oriol Brufau authored
    By mistake the specification used to say that, for items spanning
    multiple tracks, the growth limits of the tracks with an intrinsic max
    track sizing function should grow to accommodate the minimum
    contribution of the item.
    
    But this was a mistake, because an intrinsic max track sizing function
    can only be min-content or max-content. So instead of distributing the
    minimum contribution, it should be the min-content contribution.
    
    The spec has been fixed and there is a CSSWG resolution in
    https://github.com/w3c/csswg-drafts/issues/4790
    
    This patch fixes the problem by reverting r424527. The change is likely
    web compatible, since it only affects a rare edge case with 'minmax()'
    where the min sizing function is 'auto' or a fixed value smaller than
    the min-content contribution, the max sizing function is 'min-content',
    and an item whose minimum contribution is forced to be different than
    the min-content contribution, and spans multiple tracks.
    
    Bug: 1122084
    
    TEST=external/wpt/css/css-grid/layout-algorithm/grid-intrinsic-track-sizes-001.html
    TEST=fast/css-grid-layout/grid-intrinsic-maximums.html
    
    Change-Id: I1efd6e48b55fc71f37f8303c731bfbf601ca4c70
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377499Reviewed-by: default avatarManuel Rego <rego@igalia.com>
    Commit-Queue: Oriol Brufau <obrufau@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#803871}
    1d01cbaf
grid-intrinsic-maximums.html 4.3 KB