• Giovanni Ortuño Urquidi's avatar
    Revert "macOS Sandbox: Port fontloading test to V2 sandbox." · 1d2514d8
    Giovanni Ortuño Urquidi authored
    This reverts commit 1d979043.
    
    Reason for revert: SandboxMacTests failing on Mac10.10 Tests
    
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/36825
    
    [ RUN      ] SandboxMacTest.FontLoadingTest
    [1000:779:1129/160013.776478:988116558481:WARNING:test_suite.cc(257)] Test launcher output path /b/s/w/itucGTyo/.org.chromium.Chromium.qx9Sed/test_results.xml exists. Not adding test launcher result printer.
    Nov 29 16:00:13 vm132-m1.golo.chromium.org content_unittests[1000] <Error>: SeatbeltExecServer: Failed to initialize sandbox: -1 line 163: subpaths must not end with a slash
    [1000:779:1129/160013.839716:988179793263:FATAL:sandbox_mac_unittest.mm(177)] Check failed: result.server->InitializeSandbox().
    0   content_unittests                   0x000000010519dc1f base::debug::StackTrace::StackTrace(unsigned long) + 31
    1   content_unittests                   0x00000001050d871f logging::LogMessage::~LogMessage() + 223
    2   content_unittests                   0x000000010170d8b2 content::(anonymous namespace)::CheckCreateSeatbeltServer() + 562
    3   content_unittests                   0x000000010170e389 content::FontLoadingProcess() + 473
    4   content_unittests                   0x0000000104587138 base::TestSuite::Run() + 104
    5   content_unittests                   0x000000010459f43a base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 282
    6   content_unittests                   0x000000010459f2ea base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 154
    7   content_unittests                   0x00000001044df9df main + 191
    8   libdyld.dylib                       0x00007fff8f5845c9 start + 1
    
    ../../content/browser/sandbox_mac_unittest.mm:90: Failure
    Expected equality of these values:
      0
      rv
        Which is: 1
    Stack trace:
    0   content_unittests                   0x0000000102cbd93b testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
    1   content_unittests                   0x0000000102cbd2f9 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
    2   content_unittests                   0x000000010199ea19 content::(anonymous namespace)::SandboxMacTest::ExecuteWithParams(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, void (*)(sandbox::SeatbeltExecClient*)) + 1625
    3   content_unittests                   0x000000010199ca4c content::(anonymous namespace)::SandboxMacTest::ExecuteInRendererSandbox(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 172
    4   content_unittests                   0x000000010199db5e content::SandboxMacTest_FontLoadingTest_Test::TestBody() + 1278
    
    [  FAILED  ] SandboxMacTest.FontLoadingTest (286 ms)
    
    Original change's description:
    > macOS Sandbox: Port fontloading test to V2 sandbox.
    > 
    > This removes all of the obsolete unit testing code from the V1 sandbox.
    > 
    > Bug: 902597
    > Change-Id: I426e3b815e0bf23036815750aab350adbb22e068
    > Reviewed-on: https://chromium-review.googlesource.com/c/1327527
    > Commit-Queue: Greg Kerr <kerrnel@chromium.org>
    > Reviewed-by: Robert Sesek <rsesek@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#612416}
    
    TBR=kerrnel@chromium.org,rsesek@chromium.org
    
    Change-Id: I4731044d228c3b21778334b1ef2693baa1818239
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 902597
    Reviewed-on: https://chromium-review.googlesource.com/c/1356165Reviewed-by: default avatarGiovanni Ortuño Urquidi <ortuno@chromium.org>
    Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#612512}
    1d2514d8
sandbox_mac_unittest_helper.h 4.41 KB