• edchin's avatar
    Reland "[ios] Reduce pointer boilerplate in Credential Provider" · 1e0897d0
    edchin authored
    This reverts commit 525a4a22.
    
    Reason for revert:
    
    Fixed missing @end
    
    Original change's description:
    > Revert "[ios] Reduce pointer boilerplate in Credential Provider"
    >
    > This reverts commit ca2e472b.
    >
    > Reason for revert: breaks compile, see https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/4247?
    >
    > Original change's description:
    > > [ios] Reduce pointer boilerplate in Credential Provider
    > >
    > > crrev.com/c/2199891 introduces a reusable class for pointer
    > > interactions for non-button views. This class internally handles
    > > all the delegate callbacks. So usage is simplified to a single line.
    > >
    > > This CL should have no impact/change on the UI.
    > >
    > > Bug: 1073961
    > > Change-Id: I28904804916d0c112f73fe6e372bea6aede504d0
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199727
    > > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    > > Commit-Queue: edchin <edchin@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#768924}
    >
    > TBR=edchin@chromium.org,javierrobles@chromium.org
    >
    > Change-Id: Ib4e9c99203d3dbb673d49f302b342d2055561b3d
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1073961
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203138
    > Reviewed-by: Dana Fried <dfried@google.com>
    > Commit-Queue: Dana Fried <dfried@google.com>
    > Cr-Commit-Position: refs/heads/master@{#768987}
    
    TBR=edchin@chromium.org,javierrobles@chromium.org,dfried@google.com
    
    # Not skipping CQ checks because this is a reland.
    
    TBR=javierrobles@chromium.org
    
    Bug: 1073961
    Change-Id: I8534dd58ff1f7ba9f2ad2567bea894ed200b8597
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202687
    Commit-Queue: edchin <edchin@chromium.org>
    Reviewed-by: default avataredchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#769056}
    1e0897d0
BUILD.gn 1.89 KB