• Robert Liao's avatar
    Revert "gin: Set V8 context snapshot as a default snapshot" · 1e7eb050
    Robert Liao authored
    This reverts commit 231de835.
    
    Reason for revert: This change seems to break per-build bisects on Windows.
    
    Command run:
    python bisect_builds.py -o -a win64 -g 64.0.3282.24 -b 65.0.3294.0 -p S:\src\bisect\profile --use-local-cache
    
    Result:
    You are probably looking for a change made after 522661 (known good), but no later than 522662 (first known bad).
    CHANGELOG URL:
    The script might not always return single CL as suspect as some perf builds might get missing due to failure.
      https://chromium.googlesource.com/chromium/src/+log/bf8135d0bce64496b872062a07b427ddff825ec5..231de835ae50977881282c8c7fbbc2a93388d4b6
    
    Original change's description:
    > gin: Set V8 context snapshot as a default snapshot
    > 
    > Thanks to the change in V8 to make external reference table optional,
    > we can always use v8_context_snapshot.bin on platforms where it is
    > avaiable.
    > 
    > This CL sets the file as the default snapshot blob, and removes
    > setting snapshot in Isolate::CreateParam.
    > 
    > 
    > Bug: 764576, 789964
    > Change-Id: I16654eef810efcd0103e9a29659f4616c61f790b
    > Reviewed-on: https://chromium-review.googlesource.com/802654
    > Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#522662}
    
    TBR=peria@chromium.org,rmcilroy@chromium.org,haraken@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 764576, 789964
    Change-Id: Ibe8ddd99b86fd00c2c2586645350401896c49084
    Reviewed-on: https://chromium-review.googlesource.com/827705
    Commit-Queue: Robert Liao <robliao@chromium.org>
    Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#524261}
    1e7eb050
shell_runner_unittest.cc 1.58 KB