• Stepan Khapugin's avatar
    [iOS] Fix first combined character input. · 1ed06c87
    Stepan Khapugin authored
    This is a fix for broken input of the first combined character in the
    omnibox (for example in Korean).
    This introduces a regression on older OS versions when using third party
    keyboards; however this regression is *already* happening on the latest
    iOS 13 builds.
    This is a temporary fix; a proper fix is to change pre-edit behaviour
    so that it wouldn't set text or change selection in the omnibox when it
    exits pre-edit. Such a fix is a lot more fragile and will be rolled out
    behind a flag, but we need to fix the common-case input of combined
    character on latest OS now.
    
    Bug: 1030476, 988431, 875918, 873544
    Change-Id: I33248fdb17d75e215dedea11469de94dd7dc183c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980746
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Reviewed-by: default avatarRobbie Gibson <rkgibson@google.com>
    Cr-Commit-Position: refs/heads/master@{#728505}
    1ed06c87
omnibox_view_ios.mm 27.1 KB