• aruslan@chromium.org's avatar
    Update favicon URLs on FinishLoad for main frame · 1f9ba541
    aruslan@chromium.org authored
    Previously it was done on didStopLoading for _any_ frame.
    That causes a stream of spurious favicon URL updates for
    every <iframe>.
    This is now moved to on didFinishLoad and get triggered only
    for the main frame.  This ensures that icon loads always get
    initiated after all of the other page resources have been
    fetched.  Note that DidFinishDocumentLoad runs potentially
    before all subresources have been fetched, which means that
    the icon requests may compete with subresources for network
    bandwidth.  didFinishLoad is the closest place to where
    IconController does it, and we already have icons at this point.
    
    BUG=131567
    
    Review URL: https://chromiumcodereview.appspot.com/10831163
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150232 0039d316-1c4b-4281-b951-d872f2087c98
    1f9ba541
chrome_render_view_observer.h 10.3 KB