• tfarina's avatar
    tools/gn: rename char_offset to column_number · 21aff0d0
    tfarina authored
    While looking at Location and trying to understand what char offset meant,
    I got very confused, because in some languages, like Portuguese, it is
    hard to translate offset and thus understand what it means. Actually
    char offset is referring to the column number in text buffer, which is much
    easier to understand and its meaning is instantly understood, since everyone is
    familiar with the concenpt of rows (lines) and columns in a text editor.
    
    BUG=None
    TEST=gn gen + gn_unittests
    R=brettw@chromium.org
    
    Review URL: https://codereview.chromium.org/1525183002
    
    Cr-Commit-Position: refs/heads/master@{#367883}
    21aff0d0
header_checker.cc 23 KB