• Kyle Horimoto's avatar
    [CrOS PhoneHub] Ensure conversation notifications are shown as popups · 21ba15eb
    Kyle Horimoto authored
    Previously, we'd look at the notification's "priority" field to
    determine whether or not we'd show a popup or just add the notification
    to the notification shade. This caused confusion to some users, since
    some messaging apps would add this as a "minimum" or "no" priority
    notification, which would cause us to silently add the notification
    instead of adding it as a popup.
    
    This CL updates the logic so that we always show notifications as a
    popup.
    
    Fixed: 1165646
    Change-Id: Ic76bcb4eb448547ecc61c2d79828c07a3e3352b4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626030
    Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
    Commit-Queue: Regan Hsu <hsuregan@chromium.org>
    Reviewed-by: default avatarRegan Hsu <hsuregan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#842781}
    21ba15eb
phone_hub_notification_controller_unittest.cc 17.2 KB