• Roman Karasev's avatar
    Correct URL for extension with incognito:spanning mode · 2203ab11
    Roman Karasev authored
    SetUpExtensionFunction loads "main.html" for each extension by default,
    but if an extension has "incognito: spanning" in its manifest, then
    "main.html" of that extension cannot be loaded because of restriction.
    You did not see failed tests because RenderFrameHost is destroyed after
    extension function is executed in test. There is a logical race in IO/UI
    threads and it is reproduced on some PCs with Windows (on these PCs
    RenderFrameHost is destroyed earlier then extension function is
    executed).
    
    R=dtrainor@chromium.org,qinmin@chromium.org
    
    TEST: if you will wait for navigation of chrome::AddSelectedTabWithURL
    (e.g. by adding TestNavigationObserver) you can see the broblem.
    
    Bug: None
    Change-Id: Ibf8fe519fd6d041fd52ec9aa697d220a55103b53
    Reviewed-on: https://chromium-review.googlesource.com/1158070Reviewed-by: default avatarMin Qin <qinmin@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#589241}
    2203ab11
downloads_api_browsertest.cc 185 KB