• Peter Kasting's avatar
    Fix DCHECK in ~ExtensionFunction(). · 22c92d1e
    Peter Kasting authored
    If permission is denied to call an extension function, the function
    is currently destroyed without responding.  This causes a DCHECK
    failure in its destructor.
    
    Instead, ask the function to respond with an error in this case, which
    makes did_respond() return true, which avoids the DCHECK.
    
    This showed up during some trybot runs of an unrelated change, so this
    fixes some test flakiness.
    
    Bug: none
    Change-Id: I6cc5481157161b00a493504b6a403c0e492bef09
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116537
    Auto-Submit: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Ken Rockot <rockot@google.com>
    Reviewed-by: default avatarKen Rockot <rockot@google.com>
    Cr-Commit-Position: refs/heads/master@{#752655}
    22c92d1e
extension_function_dispatcher.h 6.67 KB