• Mark Mentovai's avatar
    Revert "[Mac] Preserve symbolic link in the copy_bundle_data tool." · 235d842a
    Mark Mentovai authored
    This reverts commit 6a008993.
    
    Reason for revert: https://crbug.com/966766, more information at https://crbug.com/955936 beginning at comment 13
    
    Original change's description:
    > [Mac] Preserve symbolic link in the copy_bundle_data tool.
    > 
    > The copy_bundle_data tool is implemented in terms of pax for directories
    > and ln hard links for files. The pax command does preserve symbolic
    > links within the tree that is being copied. But with the way that pax is
    > invoked by the tool, cd-ing into the source, if the source is itself
    > a symbolic link to a directory, the tree will be logically copied rather
    > than just as a symbolic link.
    > 
    > A similar issue exists with the non-directory symbolic link source case,
    > where a hard link will be produced instead of a symbolic link.
    > 
    > Fix both of these cases by specifically testing if the source is a
    > symbolic link and then re-creating it if so.
    > 
    > Bug: 955936
    > Change-Id: I69cf96878e59b0b7b121ae46cba5bc1e81f261ae
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626269
    > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    > Reviewed-by: Mark Mentovai <mark@chromium.org>
    > Commit-Queue: Robert Sesek <rsesek@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#662575}
    
    TBR=sdefresne@chromium.org,rsesek@chromium.org,mark@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 955936
    Change-Id: Ia1489278b62d0cdb33ed8980bbd6a6bcab0bb199
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628045Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
    Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
    Commit-Queue: Mark Mentovai <mark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#663076}
    235d842a
BUILD.gn 19.5 KB