• Joel Hockey's avatar
    CrOS shell_integration::GetDefaultBrowser IS_DEFAULT rather than UNKNOWN · 23629d6f
    Joel Hockey authored
    In Chrome OS, GetDefaultBrowser() runs in
    ChromeAppDelegate::NewWindowContentsDelegate::OpenURLFromTab() where it
    will either navigate internally when it detects that the current running
    chrome is the system default, else it calls
    platform_util::OpenExternal().
    
    The current implementation of CrOS OpenExternal() does an internal
    navigation, however as part of b/168506505, we are changing this to use
    guest_os::Launch() to launch VM apps.
    
    Since chrome is always the default browser in Chrome OS, we can change
    GetDefaultBrowser() to return IS_DEFAULT, which ensures OpenExternal()
    is no longer called for internal navigations and it can be used solely
    to launch VM apps.
    
    Bug: b/168506505
    Bug: 1132535
    Change-Id: If9ba4d065c9b01b1c9afd180b833a04f50c5cebc
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454769
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#814463}
    23629d6f
shell_integration_chromeos.cc 1.08 KB