• Meredith Lane's avatar
    Revert "tablet: Fix double shelf when entering guest mode." · 23821832
    Meredith Lane authored
    This reverts commit b1af29a5.
    
    Reason for revert: Crashes ash_unittests on linux-chromeos-dbg
    
    First failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/16451
    
    Original change's description:
    > tablet: Fix double shelf when entering guest mode.
    > 
    > The issue was the window was created on startup, then OnGetSwitchStates
    > triggers TabletMode to start and create the screenshot since it detects
    > a window animating. But the window doesn't destroy the screenshot because
    > a |fps_counter_| is not detected on animation end because it is created
    > in on animation schedules which happened before entering tablet mode.
    > 
    > This CL aims to prevent this and similar bugs by not taking the screenshot
    > if a window is already animating, so the only observed animation is the
    > one triggered by entering tablet mode. This may have missed data or
    > performance in some cases, but will prevent similar bugs.
    > 
    > Test: ash_unittests TabletModeControllerScreenshotTest.EnterTabletModeWhileAnimating
    > Bug: 1035356
    > Change-Id: I601d08ef50f214dbd262e5eea6baed40e5596270
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999241
    > Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    > Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#732159}
    
    TBR=xdai@chromium.org,sammiequon@chromium.org
    
    Change-Id: I738e9d46e2a9c7aa00305ba5ecf3c203ac872ecb
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1035356
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004177Reviewed-by: default avatarMeredith Lane <meredithl@chromium.org>
    Commit-Queue: Meredith Lane <meredithl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#732266}
    23821832
tablet_mode_controller_unittest.cc 70.9 KB