• manuk's avatar
    [Omnibox] Open suggestion in background tab on alt+shift enter. · 23e3b478
    manuk authored
    Currently, we opened suggestions in a background tab when holding the
    super (Linux) or command (Mac) keys and pressing enter. The code implies
    pressing the window key and pressing enter should behave likewise on
    Windows; but this didn't work because key presses aren't propagated when
    the window key is held down.
    
    With this CL, holding alt+shift and pressing enter behaves similarly.
    This
    1) brings feature parity to Windows, and
    2) is symmetric to alt+enter which opens the suggestion in a new
    foreground tab.
    
    Bug: 898277
    Change-Id: Ia6423435e9a3c9de81746ceda266803cad18704c
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937687
    Commit-Queue: manuk hovanesian <manukh@chromium.org>
    Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#719398}
    23e3b478
omnibox_view_views.cc 71.2 KB