• Jacobo Aragunde Pérez's avatar
    Accounts & sync: include title/subtitle in accessible name. · 2508937a
    Jacobo Aragunde Pérez authored
    The dialog has the accessible name "accounts and sync". It also has a
    visible title and subtitle which indicate the user account name and
    email or login status.
    
    Making these title/subtitle part of the accessible name, we expect them
    to be properly announced when the dialog is open, in particular, on Mac
    OS X where previous workarounds did not work.
    
    We partially undo the previous workaround, with a specific provision
    for crbug.com/1161166. Still, some double-speech happens due to the
    existing crbug.com/1161135.
    
    Behavior on Mac:
    
    * Reads "accounts and sync" plus title and subtitle twice due to
      crbug.com/1161135.
    
    Behavior on Linux:
    
    * Reads "accounts and sync" plus title and subtitle once thanks to a
      workaround for crbug.com/1161166.
    
    Behavior on Windows, NVDA:
    
    * Reads "accounts and sync" plus title and subtitle once.
    
    Behavior on Windows, JAWS:
    
    * Reads "accounts and sync" plus title and subtitle once when open,
      then twice when tabbing into the dialog due to crbug.com/1161135.
    
    Bug: 1078580, 1161166
    Change-Id: I483645ea482ef5101d8f9515027ea3129f46aad6
    AX-relnotes: Mac, accounts & sync: announce dialog title and subtitle.
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600976
    Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com>
    Reviewed-by: default avatarAllen Bauer <kylixrd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#839090}
    2508937a
profile_menu_view.cc 28.8 KB