• Nick Diego Yamane's avatar
    Move x11 event translation tests into ozone_x11_unittests · 25094850
    Nick Diego Yamane authored
    Ozone/X11 unit tests are kept separately so that non-X11 tests don't depend on
    X server to be performed. Having x11 event translation tests in
    events_unittests currently depends on GN config ozone_platform_x11 being set
    (more precisely after crrev.com/c/1895399), which breaks the aforementioned
    rule, when running unit tests within a ssh session, where DISPLAY env var is
    not set, among other scenarios.
    
    This fixes such regression by keeping such tests in events_unittests binary
    only for Aura/X11, while for ozone they are added to ozone_x11_unittests
    instead. This must be cleaned up once X11 is fully migrated to Ozone/X11, by
    moving x11 event translation impl and its tests into ozone/platform/x11 dir.
    
    R=spang@chromium.org
    
            --gtest_filter=XEventTranslationTest.KeyEventDomKeyExtraction
    
    Bug: 1029365
    Test: DISPLAY= ./out/linux_ozone_rel/events_unittests \
    Change-Id: I053d8dc9e2a1a26a844479c0fb503351053b12a7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036995
    Commit-Queue: Nick Yamane <nickdiego@igalia.com>
    Reviewed-by: default avatarMichael Spang <spang@chromium.org>
    Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#738467}
    25094850
BUILD.gn 18.5 KB