• Caleb Raitto's avatar
    Disable leaking views_unittests on LSAN. · 25d34c4f
    Caleb Raitto authored
    See crrev.com/c/1590404 and the linked bug for context -- the goal is to
    fix the broken memory-leak checking in Chromium's ASAN
    (AddressSanitizer) trybots, which are supposed to also run LSAN
    (LeakSanitizer).
    
    Currently-leaking tests must be fixed or disabled before leak checking
    can be enabled in the ASAN trybot.
    
    WARNING: This will result in a loss of ASAN coverage for the affected
    tests given that LSAN runs as part of the ASAN trybot.
    
    If that's not acceptable, we can wait until the leaks are fixed before
    fixing leak detection in trybots, but keep in mind that newly-introduced
    leaks Chromium-wide won't be caught until then.
    
    Bug: 961075
    Change-Id: Ib3c729da5cf45d77c9130f66cedb911434ccd03f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641562
    Commit-Queue: Caleb Raitto <caraitto@chromium.org>
    Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
    Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#666316}
    25d34c4f
menu_controller_unittest.cc 94.3 KB