• Ovidio Henriquez's avatar
    Reland "Reland "bluetooth: FakeBluetoothChooser impl."" · 25e7f8dd
    Ovidio Henriquez authored
    This is a reland of cb85732c
    
    The previous change caused the WebKit Linux Trusty ASAN trybot to fail
    because the FakeBluetoothChooser mojom JS file was not included when the
    blink_web_tests_exparchive target was isolated.
    
    Bug: 957867
    TBR=ortuno@chromium.org
    
    Original change's description:
    > Reland "bluetooth: FakeBluetoothChooser impl."
    >
    > This is a reland of 6a337f19
    >
    > This previous change caused tests to fail because of a Mojo validation
    > error, which is now taken care of by allowing the Bluetooth tests to
    > use the path to the generated Mojom files.
    >
    > Design doc:
    > https://docs.google.com/document/d/1XFl_4ZAgO8ddM6U53A9AfUuZeWgJnlYD5wtbXqEpzeg
    >
    > Original change's description:
    > > bluetooth: FakeBluetoothChooser impl.
    > >
    > > Implements the interfaces that FakeBluetoothChooser overrides. The
    > > mojom::FakeBluetoothChooser overrides are implemented by running
    > > |event_handler_| with the appropriate arguments. The BluetoothChooser
    > > overrides do nothing at the moment, since the base class is only meant
    > > to update the chooser user interface.
    > >
    > > This change also begins to partially convert a Bluetooth chooser test to test
    > > the interface and deletes the temporary tests that were created to test this
    > > API.
    > >
    > > This change reverts commit 42624492, which
    > > reverted the original change. The original change caused the
    > > new-scan-device-added.html test to fail because of a Mojo validation error
    > > resulting from not updating the
    > > third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
    > > file needed by the test.
    > >
    > > Bug: 719827, 719826, 824704, 826787
    > > Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
    > > Reviewed-on: https://chromium-review.googlesource.com/985195
    > > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
    > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    > > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#546729}
    >
    > Bug: 719827, 719826, 824704, 826787
    > Change-Id: If63a681becbb2ac0f646a11ea20b1db18d42395d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/986593
    > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#655081}
    
    Bug: 719827, 719826, 824704, 826787
    Change-Id: Iaddf24a659573d3815c9c004f6fb05a41c446616
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589845
    Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#655869}
    25e7f8dd
BUILD.gn 935 Bytes