GitLab

The settings-basic-page is designed under the assumption that all
settings-section elements are direct children of the
settings-basic-page. As a result, our previous design of the
settings-multidevice-section-container
(now settings-multidevice-page-container) was very fragile because it
put the multidevice settings-section inside the container. See
https://chromium-review.googlesource.com/c/chromium/src/+/1105185 for
context and
https://chromium-review.googlesource.com/c/chromium/src/+/1107168 for
an example of a bug fix required by this problem.

This CL maintains the settings-multidevice-page-container's ability
to hide the entire multidevice settings-section and avoid attaching
the settings-multidevice-page while putting the settings-section where
the settings-basic-page assumes it is.

Manual checks (all successful) included
    (a) the section appears immediately after loading
    (b) the mode_ property of settings-multidevice-page-container
        toggles the section's presence (including the title) multiple
        times
    (c) the section disappears when other subpages are opened (i.e. it
        does not undo the fix from CL 1107168)
    (d) other animations (e.g. opening subpages) run smoothly
    (e) the correct mode is passed to the settings-multidevice-page,
        displaying the appropriate content
    (f) all buttons work as intended after toggling, including the Set
        up" button opening the multidevice setup dialog

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I10470e8c655a55f69d6a14afa4a719d2050e2bda
Reviewed-on: https://chromium-review.googlesource.com/1109310Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570253}