• A Olsen's avatar
    Delete saml password attributes when no longer relevant. · 26209a36
    A Olsen authored
    During SAML flow, we might get extra information about when the
    password expires from the SAML IdP, which we store so we can then
    warn the user when their password expires.
    
    However, this information is no longer relevant - and will never
    be updated by the SAML IdP - if the user no longer uses SAML to log
    in. In that, case, we should simply delete it.
    
    We should also delete it if the feature that uses it is turned off -
    if an admin decides this feature is not useful to them and turns it
    off, then we should clear the data. Later if they decide to try and
    out the feature again, they shouldn't need to worry about data
    reappearing that has been stored since last time they had the
    feature enabled - that data could be very stale since it will not
    have been kept up to date. Stale data can lead to spurious
    password-expiry notifications.
    
    Bug: 930109
    Change-Id: Ia2f6abba306adea8b64a5f756579826ded8ffc16
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866750Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#709838}
    26209a36
user_session_manager.cc 101 KB