• Nate Chapin's avatar
    Presentation supplement cleanup · 26ae35fd
    Nate Chapin authored
    Merge NavigatorPresentation and Presentation, so that Presentation
    is the Supplement<Navigator>
    
    Simplify eager initialization from ModulesInitializer. Currently,
    ModulesInitializer calls PresentationReceiver::From(), which calls
    NavigationPresenation::presentation() to initialize the
    NavigatorPresentation, Presention, and PresentationReceiver. It then
    reads the PresentationReceiver off the Presentation and returns it,
    even though the return value is unused. After this CL,
    ModulesInitializer calls Presention::presentation(), which
    initializes both Presention and PresentationReceiver, and still
    ignores the return result.
    
    This also makes Presention explicitly aware of the conditional
    initialization of PresentationReceiver based on Settings.
    
    Change-Id: I4ee01f0b501eb1cb8a2c49de0ed62cfab75bd895
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518761Reviewed-by: default avatarmark a. foltz <mfoltz@chromium.org>
    Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Commit-Queue: Nate Chapin <japhet@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#825505}
    26ae35fd
BUILD.gn 1.29 KB