GitLab

Currently the RequestGlobalDump has an ambiguous dual semantic: return results
or add to the trace. For historical reasons both semantics have been collapsed 
in the same function, but this is now getting too hairy, making the codebase hard
to reason about, and caused some bugs.

Splitting the functions names as they clearly achieve two different functions
with different outcomes, specifically:
When adding the dump to the trace, clients don't care about the returned
object (which also happens to be empty). Likewise when returning the dump
(e.g. for SUMMARY_ONLY) the clients don't care about the dump_guid.

Bug: 775039
Change-Id: Ia0861bcd20775802813a35f5a138fa022521f416
Reviewed-on: https://chromium-review.googlesource.com/721540
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510055}