• Danyao Wang's avatar
    [Nav Experiment] Add TabOrderTestCase to replace some TabModelTest cases · 271a2fec
    Danyao Wang authored
    TabModelTest.AddWithOrderControllerAndGrouping is converted into
    TabOrderTestCase/testChildTabOrdering.
    
    TabModelTest.AddWithLinkTransitionAndIndex is removed because the
    behavior it tests, i.e. child tabs being inserted before parent tab, is
    not possible using public interfaces. Child tabs are always inserted
    after the parent tab.
    
    The original tests use NavigationManager::CommitPendingItem() with a
    test server. This is no longer possible with WKBasedNavigationManagerImpl.
    Updating the original tests to use embedded test server was rejected
    because TabModel is a deprecated class. Converting them to EG test allows
    the behavior to be tested with WKBasedNavigationManager and during a
    future removal of TabModel.
    
    Bug: 863026
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ia8f2b604cab93cba38142cac384a356153e95d9b
    Reviewed-on: https://chromium-review.googlesource.com/1240741
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#593721}
    271a2fec
tab_model_unittest.mm 30 KB