• Mike Wittman's avatar
    Reland "[Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header" · 2880cc9e
    Mike Wittman authored
    This reverts commit 45e2dc4e.
    
    Reason for revert: not the cause of the perf regression
    
    Original change's description:
    > Revert "[Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header"
    >
    > This reverts commit 74826cab.
    >
    > Reason for revert: testing whether this is responsible for rendering.mobile perf regression
    >
    > Original change's description:
    > > [Sampling profiler] Move ENABLE_ARM_CFI_TABLE to profiler header
    > >
    > > ENABLE_ARM_CFI_TABLE is in service of the sampling profiler on Android,
    > > and is unrelated to any debugging functionality, so move it to a
    > > buildflag header under base/profiler.
    > >
    > > Also add the required includes to the files that use it.
    > >
    > > Bug: 1129939
    > > Change-Id: I884b2128fc2ab2f6f1bec2343c59134448328529
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421443
    > > Commit-Queue: Mike Wittman <wittman@chromium.org>
    > > Commit-Queue: Lei Zhang <thestig@chromium.org>
    > > Auto-Submit: Mike Wittman <wittman@chromium.org>
    > > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#809167}
    >
    > TBR=thestig@chromium.org,wittman@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 1130974, 1129939
    > Change-Id: I00050d0bf8cd7988d0ad8969f0b8a29e8accf669
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432308
    > Reviewed-by: Mike Wittman <wittman@chromium.org>
    > Commit-Queue: Mike Wittman <wittman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#810801}
    
    TBR=thestig@chromium.org,wittman@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1130974
    Bug: 1129939
    Change-Id: I3180fd8161b3df701d467d1a028d0e504938dfe1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435778Reviewed-by: default avatarMike Wittman <wittman@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Commit-Queue: Mike Wittman <wittman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#811309}
    2880cc9e
thread_profiler.cc 18 KB