• Mark Mentovai's avatar
    mac: Don't run dump_syms or produce a .dSYM archive in component builds · 288b46ae
    Mark Mentovai authored
    dump_syms and the .dSYM archiver are intended for use on official
    Chrome-branded builds. While they work in other configurations, they
    draw from a static list of data sources that match what ships in an
    official build. Component builds break code out into many other modules,
    none of which are in the static list. Any output produced by the
    chrome_dump_syms or chrome_dsym_archive targets would be misleadingly
    unusable in a component build.
    
    To avoid producing these pointless artifacts, disable their function
    (while leaving the target names viable via empty "group" definitions, in
    case anyone depends on them.)
    
    Note that the chrome target never depends on either of these targets in
    a component build. These targets are only reachable explicitly or via a
    full build.
    
    Bug: 991206
    Change-Id: I8b6e09f78896da1e02f8dabd2d60d0fd42df2ef4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742213Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
    Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Mark Mentovai <mark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#685358}
    288b46ae
BUILD.gn 58.1 KB