GitLab

Per //extensions/shell/README, app_shell is only officially supported on
ChromeOS, and support for Chrome Apps on Mac won't be developed further.
This removes the bundled version of the app_shell and turns it into a
standalone executable. This reduces the platform-specific maintenance burden
for the extensions_browsertests.

This moves the SetAmIBundleOverride() call from the BrowserTestBase subclass
to ContentBrowserTest. While content_browsertests uses the bundled
Content Shell.app, other browsertests do not use bundled binaries and
so this does not belong in the base class.

Bug: 844401, 689306
Test: All extensions_browsertests continue to run.
Change-Id: I300de23bd9cb1a845bd06799887ad386e774b6c7
Reviewed-on: https://chromium-review.googlesource.com/1134217
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575312}