• Miguel Casas's avatar
    Gpu FeatureFlags: do not signal chromium_image_xr30 on GLES 3.0 · 28d782ef
    Miguel Casas authored
    Gpu FeatureInfo::FeatureFlags.chromium_image_xr30 doesn't work
    on Swiftshader because it doesn't support GL_BGRA(_EXT) for
    glImage2D(), making our texture uploads fail.  This failure is
    legit because GLES 3.0 supports only GL_RGBA data format.
    
    So this CL disables chromium_image_xr30 until the swiftshader
    bug is addressed (adding a TODO), and also corrects the OpenGL
    version where GL_EXT_texture_type_2_10_10_10_REV was inlined,
    which is 3.3 and not 4.2 as I wrote erroneously before, oops!
    (see http://go/gl3.3)
    
    Bug: 808172, swiftshader:95
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Change-Id: I0c6952b14ff53fb504bf292c51a8bc2ffe612918
    Reviewed-on: https://chromium-review.googlesource.com/899462Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#534216}
    28d782ef
feature_info.cc 74.5 KB