• Tom Anderson's avatar
    Fix crash in X11SoftwareBitmapPresenter teardown · 2903992a
    Tom Anderson authored
    If XGetWindowAttributes() fails in X11SoftwareBitmapPresenter(), |shm_pool_|
    will never be constructed. However, we assumed in several places that
    |shm_pool_| was non-null, which can cause a crash. For example
    ~X11SoftwareBitmapPresenter() calls shm_pool_->Teardown() without a check.
    
    This CL adds null checks in the appropriate places.
    
    BUG=1015124
    R=rjkroege
    
    Change-Id: I19eabf89961632f5573a4f0020748012aa0d6c8f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879502
    Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
    Reviewed-by: default avatarRobert Kroeger <rjkroege@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#710072}
    2903992a
x11_software_bitmap_presenter.cc 9.76 KB