• Sergey Silkin's avatar
    Reland "Remove deprecated enable-webrtc-hw-{h264,vp8,vp9}-encoding flags" · 290641cb
    Sergey Silkin authored
    This reverts commit 3475028d.
    
    Reason for revert: M80 release blocker. Bug 1046501.
    
    Original change's description:
    > Revert "Remove deprecated enable-webrtc-hw-{h264,vp8,vp9}-encoding flags"
    > 
    > This reverts commit a387ca32.
    > 
    > Reason for revert: M80 Stable blocker bug 1046501
    > 
    > Original change's description:
    > > Remove deprecated enable-webrtc-hw-{h264,vp8,vp9}-encoding flags
    > > 
    > > This CL removes the 3 flags  enable-webrtc-hw-{h264,vp8,vp9}-encoding
    > > because they were deprecated in M76 and will be hidden in M78.  These
    > > flags are used in peerconnection/rtc_video_encoder_factory.cc to
    > > filter the supported codecs to be added to the SDP.
    > > 
    > > The same filtering effect can be obtained by using the still existing
    > > flag --disable-webrtc-hw-encoding which is also surfaced to
    > > chrome:flags and used in peerconnection/video_codec_factory.cc [1],
    > > albeit at a coarser granularity: no codec-level enable/disable is
    > > available.
    > > 
    > > [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/peerconnection/video_codec_factory.cc?type=cs&q=IsWebRtcHWEncodingEnabled&g=0&l=180
    > > 
    > > Bug: 599650
    > > Change-Id: I35bde6cd50c88ca8641dd9a6bd5a3e44394cde43
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863153
    > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    > > Auto-Submit: Miguel Casas <mcasas@chromium.org>
    > > Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#708063}
    > 
    > TBR=dgozman@chromium.org,dcheng@google.com,mcasas@chromium.org,pfeldman@chromium.org,foolip@chromium.org,hiroh@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 599650
    > Change-Id: I6473fb68d3aac1e937da9ded8138befdd857e762
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028852
    > Reviewed-by: Krishna Govind <govind@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#736659}
    
    TBR=dgozman@chromium.org,dcheng@google.com,mcasas@chromium.org,pfeldman@chromium.org,govind@chromium.org,foolip@chromium.org,hiroh@chromium.org,benmason@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 599650
    Change-Id: Idef433d7d615f517f404f9c265c14dea494a6115
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033246
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Reviewed-by: default avatarMiguel Casas <mcasas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#737329}
    290641cb
flag_descriptions.cc 175 KB