• Nico Weber's avatar
    mac/ios: Use real response files instead of -filelist when calling libtool · 2923377e
    Nico Weber authored
    This is a reland of 3aed6673
    The change seems to make ld64 segfault sometimes. It's not clear why,
    but I'm guessing it's related to how we passed the filelist to ld64
    previously, but now we hand the rspfile to clang which reads it and
    then re-writes it as rspfile internally. This reland only relands the
    bit for "alink", which calls libtool directly and doesn't involve either
    clang nor ld64. This part is hopefully safe to land.
    
    Original change's description:
    > Reland "mac/ios: Use real response files instead of -filelist."
    >
    > This is a reland of 5e46febb
    >
    > Original change's description:
    > > mac/ios: Use real response files instead of -filelist.
    > >
    > > Xcode 12 added support for real response files, so let's use them.
    > > Allows making response file contents more like on other systems
    > > (libs, solibs, frameworks, swiftmodules now go in the rsp file too),
    > > and makes it theoretically possible to have object files with spaces
    > > in their name.
    > >
    > > No intentional behavior change.
    > >
    > > Bug: none
    > > Change-Id: I8c2d6ff1abd47261bf7674dc7bf4506814681ad4
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527621
    > > Auto-Submit: Nico Weber <thakis@chromium.org>
    > > Commit-Queue: Brett Wilson <brettw@chromium.org>
    > > Reviewed-by: Brett Wilson <brettw@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#825480}
    >
    > Bug: none
    > Change-Id: Ib355508d2d45ab3ddf9ece76b6e95106c784fde9
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530350
    > Auto-Submit: Nico Weber <thakis@chromium.org>
    > Reviewed-by: Tommy Martino <tmartino@chromium.org>
    > Reviewed-by: Mark Mentovai <mark@chromium.org>
    > Commit-Queue: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#826282}
    
    Bug: 1147968
    Change-Id: I0d077355924569ef537da7e66c4d346ec5fc6eea
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533546
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#826901}
    2923377e
BUILD.gn 22.8 KB