• danakj's avatar
    Avoid racing RequestNewLayerTreeFrameSink with DoDeferredClose. · 292b63e6
    danakj authored
    CloseWidgetSoon will post DoDeferredClose, which will stop new frame
    sinks from being made.
    
    However WebPagePopupImpl destroys its Page/MainFrame etc when it calls
    CloseWidgetSoon, which also detaches the WebFrameWidget. Then if a
    RequestNewLayerTreeFrameSink was already in the task queue, it would
    run before DoDeferredClose, and crash when it tries to get the URL from
    the non-existant WebFrameWidget/MainFrame.
    
    R=piman@chromium.org
    
    Change-Id: I94ec48915b6dba207f783a9d3b380476e97da9da
    Bug: 896836
    Reviewed-on: https://chromium-review.googlesource.com/c/1342774Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#609423}
    292b63e6
render_widget.cc 124 KB