• Henrique Nakashima's avatar
    Reland "Break down WebContentsStateBridge#createHistoricalTab()" · 29c0a512
    Henrique Nakashima authored
    Reland note: Fixed version without NPE.
    
    WebContentsStateBridge#createHistoricalTab() can be accomplished by
    calling other methods:
    - WebContentsStateBridge#restoreContentsFromByteBuffer()
    - WebContentsStateBridge#createHistoricalTabFromContents()
    - WebContents#destroy()
    
    Replace it with these calls.
    
    Bug: 1090048
    
    Original change's description:
    > Revert "Break down WebContentsStateBridge#createHistoricalTab()"
    >
    > This reverts commit 864ff6e1.
    >
    > Reason for revert: crbug.com/1100325
    > TBR=dtrainor@chromium.org,jinsukkim@chromium.org,hnakashima@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 1090048
    > Change-Id: I73d490b12526ab8f26171f8c4fbf42fcbe284c17
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273682
    > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
    > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#783626}
    
    TBR=dtrainor@chromium.org,jinsukkim@chromium.org,hnakashima@chromium.org
    
    
    Bug: 1090048
    Change-Id: Ie818a2ab7a9958d60cddac542151d7b0bc487b28
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274200Reviewed-by: default avatarJinsuk Kim <jinsukkim@chromium.org>
    Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
    Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#784072}
    29c0a512
web_contents_state.cc 22.7 KB