• Jérémie Boulic's avatar
    Files app: Generate JS module for directory_tree.js in foreground page · 2a455fbc
    Jérémie Boulic authored
    In //ui/file_manager/file_manager/foreground/js/:
    - dialog_types.js
    - directory_tree_naming_controller.js
    - mock_navigation_list_model.js
    
    in //ui/file_manager/file_manager/foreground/js/ui/:
    - directory_tree.js
    - directory_tree_unittest.m.js
    
    Add "jscomp_off=duplicate" to the closure flags for unit tests. This
    flag is present in the `default_closure_args` used for non unit tests,
    and is required here for the proper compilation of
    //ui/webui/resources/js/cr/ui/tree.m.js.
    Without this flag, closure complains about rowElementDepthStyleHandler
    being redefined after defining a getter and a setter for it.
    
    Rename TreeItem in directory_tree.js to FilesTreeItem, to have the
    necessary distinction between this class and the `TreeItem` defined
    within the cr.ui namespace.
    
    Bug: 1133186, 1134497
    Change-Id: I6b5b5a64a20b9e70e2498ea9a8af33e048ae4efc
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616648
    Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
    Auto-Submit: Jeremie Boulic <jboulic@chromium.org>
    Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#841965}
    2a455fbc
file_manager_jstest.cc 8.44 KB