• dpapad's avatar
    Serve chrome://apps from a regular WebUIDataSource. · 2a565a3b
    dpapad authored
    Previously because of the long history of this page (which at some
    point served as the NTP, aka NTP4) it was served by a custom class
    which delegated logic to NTPResourceCache. There is no good reason to
    use the NTPResourceCache for chrome://apps anymore, AFAIK.
    
    Using a WebUIDataSource makes a lot of things simpler, like registering
    resources, localized strings, load time data, and many more.
    
    This is in preparation of possibly migrating chrome://apps to JS modules
    (TBD). Regardless, moving away from NTPResourceCache is a positive step.
    
    Bug: 1168053
    Change-Id: If82d634c8d7e699dc1c906517c23c40bfaa0b6b8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629855Reviewed-by: default avatarEsmael Elmoslimany <aee@chromium.org>
    Commit-Queue: dpapad <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#846035}
    2a565a3b
app_launcher_handler.h 10.8 KB