GitLab

This reverts commit a86c92901aa9f21db709d7b40d1fcf0d472570d2.

Reason for revert: We actually want this change reverted :). The original CL was bad, the revert was a manual thing done by the sheriff. The GoB fix then re-landed this, and now we want to reland it again.
Original change's description:
> Reland "WebApp: Extract BookmarkAppHelper's gfx stuff into a separate file."
> 
> This is a reland of c8299015
> to revert findit revert of the above in https://chromium.googlesource.com/chromium/src/+/224eb4663f904ffc0c1356fe5f1d83fc4afc2c90
> Why? Due to Gerrit outage http://crbug.com/872722, we are reverting this CL.
> Please, re-land it after all clear is given.
> If you have questions, please ask on the bug. Sorry for the inconvenience.
> 
> Original change's description:
> > WebApp: Extract BookmarkAppHelper's gfx stuff into a separate file.
> >
> > Extract all the low-level skia/gfx/color_util stuff as
> > ResizeIconsAndGenerateMissing function.
> >
> > This is a cut-and-paste CL, no behavior changes.
> >
> > Notes:
> > - WebApplicationInfo::IconInfo becomes IconInfo. TODO for next CL:
> > Merge IconInfo and BitmapAndSource - they are essentially the same.
> >
> > - BookmarkAppHelperExtensionServiceTest.LinkedAppIconsAreNotChanged test
> > was always broken (a bug in ValidateAllIconsWithURLsArePresent helper)
> > https://codereview.chromium.org/1066623008/patch/80001/90005
> >
> > Bug: 860581
> > Change-Id: I0d866ac323f8dfdb409b69b22fac796155b1da23
> > Reviewed-on: https://chromium-review.googlesource.com/1166751
> > Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Reviewed-by: Dominick Ng <dominickn@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581827}
> 
> Bug: 860581
> Change-Id: If155ed6aedda2c7256f3ab707d4d335eeab26b6f
> Reviewed-on: https://chromium-review.googlesource.com/1169795
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

TBR=ortuno@chromium.org,loyso@chromium.org,tandrii@chromium.org,dominickn@chromium.org

Change-Id: I8c9475f3ed6ddb87bc09c0b1f8317147134ecbb1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860581
Reviewed-on: https://chromium-review.googlesource.com/1169928Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581908}