Skip to content

GitLab

T
tangled
Switch branch/tag
Find file BlameHistoryPermalink
  • hshi@google.com's avatar
    Decouple loading of channel info and the rest of machine statistics. · 2a95da4f
    hshi@google.com authored 
    Related CL: crrev.com/173507 - that CL calls StatisticsProvider::Init()
in PreEarlyInitialization stage to obtain channel info early. However
it also has a side-effect to load machine statistics early. After this CL
we start to observe that sometimes the crossystem tool hangs.

Ideally the tool hang should be root caused but it is timing sensitive
and also extremely rare.

The current CL makes StatisticsProvider::StartLoadingMachineStatistics()
a separate and explicit call, so that the crossystem tool can be invoked
later at PostBrowserStart stage. Hopefully by restoring the timing we
can eliminate the tool hang.

BUG=167671
TEST=CQ, manually verified that machine statistics is still available
under chrome://settings in the "bios_info" section.

Review URL: https://codereview.chromium.org/11778025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175434 0039d316-1c4b-4281-b951-d872f2087c98
    2a95da4f
chrome_browser_main_chromeos.cc 31.4 KB