• Dominic Mazzoni's avatar
    Revert "[signin] Add reauth browser tests with a fake Gaia page" · 2d660071
    Dominic Mazzoni authored
    This reverts commit 62ff616d.
    
    Reason for revert: 
    Both of these are failing on MSAN:
    SigninReauthViewControllerBrowserTest.CancelReauthDialog
    SigninReauthViewControllerBrowserTest.ConfirmReauthDialog
    
    Original change's description:
    > [signin] Add reauth browser tests with a fake Gaia page
    > 
    > This CL adds a new set of tests for the reauth dialog. These tests
    > check interactions with a Gaia Reauth endpoint that is imitated through
    > an EmbeddedTestServer.
    > 
    > The main "embedded/xreauth/chrome" endpoint operates in two modes:
    > - In the default mode, the endpoint redirects to the "challenge" URL
    > whose response can be controlled within the test by a
    > ControllableHttpResponse.
    > - If the "?done" query is present, the endpoint returns the
    > HTTP_NO_CONTENT response that signifies a successful reauth.
    > 
    > The CL also extracts common test code into test suite functions to
    > reduce the code duplication and make the tests code more readable.
    > 
    > Bug: 1045515
    > Change-Id: I89d4aac57ef25168def1341fb63b1a7498dcfa0f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225396
    > Commit-Queue: Alex Ilin <alexilin@chromium.org>
    > Reviewed-by: David Roger <droger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#774205}
    
    TBR=droger@chromium.org,alexilin@chromium.org
    
    Change-Id: I9e322b00bb98f9394b81fda2a0e62bf5db5cd9e9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1045515, 1090451
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225852Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#774265}
    2d660071
signin_reauth_view_controller_browsertest.cc 5.24 KB