• behdad's avatar
    Reland "Record latency for Impl thread in case of no begin main frame." · 2b276379
    behdad authored
    This is a reland of 2fcffb28
    
    The cause of crashes on webview_instrumentation_test_apk was that reporter was
    terminated without a termination status (instance being destroyed) in
    TerminateReporter method of compositor_frame_reporter.
    
    Original change's description:
    > Record latency for Impl thread in case of no begin main frame.
    >
    > This CL reports the latency in case of no begin main frame.
    > This can happen in any of the scenarios below:
    >
    > 1) WillBeginImplFrame -> DidFinishImplFrame -> DidSubmitCompositorFrame
    >
    > 2) WillBeginImplFrame -> WillBeginMainFrame -> BeginMainFrameAborted ->
    > DidFinishImplFrame -> DidSubmitCompositorFrame
    >
    > 3) WillBeginImplFrame -> WillBeginMainFrame -> DidFinishImplFrame ->
    > BeginMainFrameAborted -> DidSubmitCompositorFrame
    >
    > In these cases there will be no latency to report for stages of:
    > - SendBeginMainFrameToCommit
    > - Commit
    > - EndCommitToActivation
    > But the latency will be reported for the remaining stages.
    >
    > Bug: chromium:1003038
    > Change-Id: Id0d6a65603b2b15a0ee04a6974a4bd0b2a5a803b
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799026
    > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
    > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#705964}
    
    Bug: chromium:1003038
    Change-Id: I95651557c6e50b9f2e8ee3ae1043616fff8c88ee
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865535
    Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
    Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#707357}
    2b276379
compositor_frame_reporting_controller.cc 9.27 KB