• Wenbin Zhang's avatar
    Reland "Set limit for field trial parameters length." · 2c0483fc
    Wenbin Zhang authored
    This is a reland of 1547c775
    
    Original change's description:
    > Set limit for field trial parameters length.
    >
    > Windows has a limit of 32767 on a command line. When testing with field
    > trails, the command to launch chrome.exe may exceed the limit if there're
    > too many field trial configs passed as parameters. This was causing
    > the chrome perf waterfall to completely fail on Windows.
    >
    > This CL added a presubmit check to see whether the configs under Windows
    > will exceed the limit of 31000.
    >
    > Bug: chromium:1045530
    > Change-Id: I9d181783f1bdad58eeba802583c052bfd0321c6f
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021468
    > Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#735981}
    
    Bug: chromium:1045530
    Change-Id: I04b664b6f8a6b21f6202df95d912bd220d669728
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025511
    Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
    Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#736166}
    2c0483fc
PRESUBMIT.py 11.7 KB