• Alice Boxhall's avatar
    Revert "Chrome OS: Use layer animation browser window frame activation animation." · 2c65720a
    Alice Boxhall authored
    This reverts commit 0dce55ff.
    
    Reason for revert: This has caused a crash in many CrOS tests: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20119
    
    Original change's description:
    > Chrome OS: Use layer animation browser window frame activation animation.
    > 
    > This is a revised version of original attempt crrev.comc/c/2166804.
    > Instead of creating a new layers, this clone and animate the window's layer,
    > but makes sure that the animating layer is at the bottom of other layers
    > within the window.
    > 
    > * It adds a invisible view with a layer
    >   at the bottom of the non_client_view (no frame w/o this, so we can exclude such case).
    > * Adds the animating layer as a child of this view, with
    >   "SetMasksToBounds(false)" so that it will not be clipped during animation.
    > * Once animation is done, this animating, old layer will be removed.
    > 
    > Bug: 1073685
    > Test: covered by unittests.
    > Change-Id: Ib9ae60694fb461dda354fea4fd52e4e01186a6a7
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335811
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#800827}
    
    TBR=sky@chromium.org,oshima@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1073685
    Change-Id: I093849df58f25a46a021f923daab1ab1faa1efee
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371383Reviewed-by: default avatarAlice Boxhall <aboxhall@chromium.org>
    Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#800896}
    2c65720a
non_client_frame_view_ash.cc 14.6 KB