GitLab

Before this CL: With the feature EnablePasswordsAccountStorage enabled,
calls to PasswordAutofillAgent::MaybeCheckSafeBrowsingReputation were
always bypassed (as an unintended side effect of showing the autofill
dropdown even if there are no password suggestions). This caused the
following two tests to fail with the feature enabled:
PasswordAutofillAgentTest.CheckSafeBrowsingReputationWhenUserStartsFillingUsernamePassword
NavigationMetricsRecorderBrowserTest.PasswordEntry_EngagementLevel

This CL rearranges the logic so that MaybeCheckSafeBrowsingReputation
gets called again when appropriate.

Bug: 1095984, 1093310
Change-Id: If51032f09463ec25bb239ffa410af822d13b4678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247795Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779716}