• Mike Reed's avatar
    Opt into new picture-shader sampling · 2d283b78
    Mike Reed authored
    Test images rebaselined to account for the new behavior in skia's
    picture-shader when a post-raster sampling is required.
    
    Note on change to cc_unittest:
    
    Several of these tests try to compare output between a direct draw
    (RasterExpectedBitmap) and an OOPR draw (Raster), expecting the two
    results to be identical.
    
    However, OOP doesn't *always* produce the same Skia calls as direct;
    if it sees a picture-shader (PaintShader::MakePaintRecord) it will
    convert this to a pre-scaled picture-image-shader, and then draw with
    that. This makes it invalid to always require *exact* pixel comparisons,
    since it may have sent (slightly) different commands/floats to the GPU.
    
    This CL (with a change to picture-shader's handling of post-raster
    sampling) stumbled over such a different (perhaps only on
    Nexus5-lollipop). To make the test more robust, those tests now
    call set_has_animated_images(true) to force converting kRasterAtScale
    to kFixedScale for both direct and oop.
    
    Change-Id: Ic0ce9128c75ea598f593187f3a1b54e2c0c4cd8d
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619838Reviewed-by: default avatarVasiliy Telezhnikov <vasilyt@chromium.org>
    Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
    Reviewed-by: default avatarFlorin Malita <fmalita@chromium.org>
    Commit-Queue: Mike Reed <reed@google.com>
    Cr-Commit-Position: refs/heads/master@{#844395}
    2d283b78
SkUserConfig.h 9.23 KB