• Etienne Pierre-doray's avatar
    [TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks. · 2d56a039
    Etienne Pierre-doray authored
    This CL uses ScopedBlockingCall to mark blocking calls in /components/download.
    
    This CL was created by replacing calls to AssertBlockingAllowed()
    with instantiations of ScopedBlockingCall(MAY_BLOCK).
    I kindly ask the reviewer to make sure of the following:
      - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
        If this is not the case, ScopedBlockingCall should be instantiated
        closer to the blocking call. See scoped_blocking_call.h for more
        info. Please let me know when/where the blocking call happens if this needs
        to be changed.
      - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
        BlockingType for more info. While I assumed MAY_BLOCK by default, that might
        not be the best fit if we know that this callsite is guaranteed to block.
      - The ScopedBlockingCall's scope covers the entirety of the blocking operation
        previously asserted against by the AssertBlockingAllowed().
    
    This CL was uploaded by git cl split.
    
    R=shaktisahu@chromium.org
    
    TBR=shaktisahu@chromium.org
    
    Bug: 874080
    Change-Id: Icf3e527d0d344e099a9debe054a8046273baebef
    Reviewed-on: https://chromium-review.googlesource.com/1191096
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#594725}
    2d56a039
quarantine_mac.mm 9.54 KB