• battre's avatar
    Revert of Enable more benchmark_smoke_unittest coverage (patchset #4 id:100001... · 2d93642c
    battre authored
    Revert of Enable more benchmark_smoke_unittest coverage (patchset #4 id:100001 of https://codereview.chromium.org/1144193002/)
    
    Reason for revert:
    Reverting due to flaky perf tests (see crbug.com/490130 for details).
    
    Original issue's description:
    > Enable more benchmark_smoke_unittest coverage
    >
    > Previously, benchmark_smoke_unittest has a heuristic to pick
    > a benchmark for smoke testing if the benchmark uses a test
    > in measurement directory.
    > This patch removes that check, and instead provide a black
    > list of benchmarks module that we exclude the
    > benchmark_smoke_unittest to avoid high CQ time.
    >
    > This helped increases benchmark smoke coverage from 14 benchmarks -> 33 benchmarks (one in each benchmark module).
    >
    > On my local linux machine, this increases the cycle time of
    > benchmark_smoke_unittest from 20s -> 1m7s.
    >
    > BUG=490130
    > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
    >
    > Committed: https://crrev.com/65014162e48a7f5881e8b282dd9e8dc17c5aa7c4
    > Cr-Commit-Position: refs/heads/master@{#330909}
    
    TBR=sullivan@chromium.org,dtu@chromium.org,nednguyen@google.com
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=490130
    
    Review URL: https://codereview.chromium.org/1143363006
    
    Cr-Commit-Position: refs/heads/master@{#330923}
    2d93642c
benchmark_smoke_unittest.py 4.77 KB