• Ren-Pei Zeng's avatar
    [CrOS VCD] Differentiate usage flags for preview/reprocessing buffers · 2dd1098a
    Ren-Pei Zeng authored
    crrev.com/c/2234684 introduces a new buffer usage flag for hardware VEA
    (SCANOUT_VEA_READ_CAMERA_AND_CPU_READ_WRITE). On Kukui this changes
    buffer layout, and the camera driver failed to capture correct content
    into the buffer in the RAW->YUV reprocessing case.
    
    Since the reprocessing YUV buffer is not used for video encoding, this
    CL changes the buffer usage for that use case back to the original
    (SCANOUT_CAMERA_READ_WRITE).
    
    This CL also cleans up places that hard-code buffer usage, or makes it
    verbose when it has to do so.
    
    Bug: 1105154
    Test: capture_unittests
    Test: CCA preview, video recording, take normal/Portrait photo (with #zero-copy-video-capture flag on and off)
    Change-Id: I1c3d88f361faad43994fbf6fedc9514de7947366
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315725Reviewed-by: default avatarRicky Liang <jcliang@chromium.org>
    Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
    Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#792194}
    2dd1098a
camera_buffer_factory.h 1.2 KB