Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
T
tangled
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • eriksson monteiro
  • tangled
  • Repository

Switch branch/tag
  • tangled
  • chrome
  • browser
  • resources
  • ad_networks.dat
Find file HistoryPermalink
  • rdevlin.cronin@chromium.org's avatar
    Resubmit: Add real file for AdNetworks DB · 2e109286
    rdevlin.cronin@chromium.org authored May 10, 2014
    This is a resubmit of https://codereview.chromium.org/268063004/.
    
    The previous version was reverted because it caused a memory leak. This was a
    problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which
    has been fixed.
    
    Details:
    Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory
    (which according to the class comment, "the ref counting does not matter" [1]),
    the ref-counting _does_ matter. The fix for this went in as part of a refactor
    in https://codereview.chromium.org/263953003/.
    
    [1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44
    
    BUG=357204
    
    TBR=jhawkins@chromium.org (previously approved)
    TBR=felt@chromium.org (very minor changes)
    
    Review URL: https://codereview.chromium.org/274563003
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269494 0039d316-1c4b-4281-b951-d872f2087c98
    2e109286
ad_networks.dat 4.24 KB

Download (4.24 KB)

Replace ad_networks.dat

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.